Re: [Mesa-dev] [PATCH 2/2] nir: Do not use continue block after removing it.

2018-07-18 Thread Jason Ekstrand
Also, Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107275 On Wed, Jul 18, 2018 at 9:16 PM Jason Ekstrand wrote: > On Sat, Jul 14, 2018 at 4:26 PM Bas Nieuwenhuizen > wrote: > >> Reinserting code directly before a jump means the block gets split >> and merged, removing the original bl

Re: [Mesa-dev] [PATCH 2/2] nir: Do not use continue block after removing it.

2018-07-18 Thread Jason Ekstrand
On Sat, Jul 14, 2018 at 4:26 PM Bas Nieuwenhuizen wrote: > Reinserting code directly before a jump means the block gets split > and merged, removing the original block and replacing it in the > process. > > Hence keeping a pointer to the continue block over a reinsert > causes issues. > > This co

[Mesa-dev] [PATCH 2/2] nir: Do not use continue block after removing it.

2018-07-14 Thread Bas Nieuwenhuizen
Reinserting code directly before a jump means the block gets split and merged, removing the original block and replacing it in the process. Hence keeping a pointer to the continue block over a reinsert causes issues. This code changes nir_opt_if to simply look for the new continue block. CC: 18.