On 09/03/2012 11:35 AM, Eric Anholt wrote:
Kenneth Graunke writes:
I'm really ambivalent about these patches.
1. I'm not a huge fan of the name "have_version"...it sounds like it
would return whether a driver supports a given version, not whether the
current context's version is a certain val
Kenneth Graunke writes:
> I'm really ambivalent about these patches.
>
> 1. I'm not a huge fan of the name "have_version"...it sounds like it
> would return whether a driver supports a given version, not whether the
> current context's version is a certain value.
>
> 2. Personally I think ctx->Ve
On Fri, Aug 31, 2012 at 10:16 PM, Kenneth Graunke wrote:
> I'm really ambivalent about these patches.
>
> 1. I'm not a huge fan of the name "have_version"...it sounds like it
> would return whether a driver supports a given version, not whether the
> current context's version is a certain value.
I'm really ambivalent about these patches.
1. I'm not a huge fan of the name "have_version"...it sounds like it
would return whether a driver supports a given version, not whether the
current context's version is a certain value.
2. Personally I think ctx->Version <= XY is clearer than
!_mesa_hav
On Fri, Aug 31, 2012 at 11:52 AM, Jordan Justen
wrote:
> Signed-off-by: Jordan Justen
> ---
> diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c
> index b713f5f..00852ad 100644
> --- a/src/mesa/main/enable.c
> +++ b/src/mesa/main/enable.c
> @@ -1041,7 +1041,7 @@ _mesa_set_enable(struct
Signed-off-by: Jordan Justen
---
src/mesa/drivers/dri/nouveau/nouveau_context.c |2 +-
src/mesa/main/context.h|3 ++-
src/mesa/main/enable.c |4 ++--
src/mesa/main/fbobject.c | 28
src/mes
