Re: [Mesa-dev] [PATCH 2/2] mesa: use strdup() instead of _mesa_strdup()

2015-03-12 Thread Brian Paul
On 03/10/2015 08:47 PM, Ian Romanick wrote: On 03/10/2015 07:47 PM, Ian Romanick wrote: On 03/10/2015 06:42 PM, Brian Paul wrote: We were already using strdup() in various places in Mesa. Get rid of the _mesa_strdup() wrapper. All the callers pass a non-NULL argument so the NULL check isn't n

Re: [Mesa-dev] [PATCH 2/2] mesa: use strdup() instead of _mesa_strdup()

2015-03-11 Thread Emil Velikov
On 11/03/15 01:42, Brian Paul wrote: > We were already using strdup() in various places in Mesa. Get rid > of the _mesa_strdup() wrapper. All the callers pass a non-NULL > argument so the NULL check isn't needed either. Last time I've tried using strdup with MSVC there were a few warnings. Iirc t

Re: [Mesa-dev] [PATCH 2/2] mesa: use strdup() instead of _mesa_strdup()

2015-03-11 Thread Jose Fonseca
On 11/03/15 01:42, Brian Paul wrote: We were already using strdup() in various places in Mesa. Get rid of the _mesa_strdup() wrapper. All the callers pass a non-NULL argument so the NULL check isn't needed either. --- src/mesa/main/imports.c | 18 -- src/mesa/main

Re: [Mesa-dev] [PATCH 2/2] mesa: use strdup() instead of _mesa_strdup()

2015-03-10 Thread Ian Romanick
On 03/10/2015 07:47 PM, Ian Romanick wrote: > On 03/10/2015 06:42 PM, Brian Paul wrote: >> We were already using strdup() in various places in Mesa. Get rid >> of the _mesa_strdup() wrapper. All the callers pass a non-NULL >> argument so the NULL check isn't needed either. >> --- >> src/mesa/mai

Re: [Mesa-dev] [PATCH 2/2] mesa: use strdup() instead of _mesa_strdup()

2015-03-10 Thread Ian Romanick
On 03/10/2015 06:42 PM, Brian Paul wrote: > We were already using strdup() in various places in Mesa. Get rid > of the _mesa_strdup() wrapper. All the callers pass a non-NULL > argument so the NULL check isn't needed either. > --- > src/mesa/main/imports.c | 18 -- >

[Mesa-dev] [PATCH 2/2] mesa: use strdup() instead of _mesa_strdup()

2015-03-10 Thread Brian Paul
We were already using strdup() in various places in Mesa. Get rid of the _mesa_strdup() wrapper. All the callers pass a non-NULL argument so the NULL check isn't needed either. --- src/mesa/main/imports.c | 18 -- src/mesa/main/imports.h | 3 --- src/mesa