Re: [Mesa-dev] [PATCH 2/2] mesa: fix error handling for glMapBufferRange

2011-09-19 Thread Yuanhan Liu
On Mon, Sep 19, 2011 at 11:54:44AM -0700, Eric Anholt wrote: > On Mon, 19 Sep 2011 18:25:55 +0800, Yuanhan Liu > wrote: > > Accroding the man page, GL_INVALID_VALUE would generated if access has any > > bits set other than those valid defined bits. > > > > Signed-off-by: Yuanhan Liu > > It woul

Re: [Mesa-dev] [PATCH 2/2] mesa: fix error handling for glMapBufferRange

2011-09-19 Thread Eric Anholt
On Mon, 19 Sep 2011 18:25:55 +0800, Yuanhan Liu wrote: > Accroding the man page, GL_INVALID_VALUE would generated if access has any > bits set other than those valid defined bits. > > Signed-off-by: Yuanhan Liu It would be nice to see simple piglit tests created for these sorts of API validatio

Re: [Mesa-dev] [PATCH 2/2] mesa: fix error handling for glMapBufferRange

2011-09-19 Thread Brian Paul
On 09/19/2011 04:25 AM, Yuanhan Liu wrote: Accroding the man page, GL_INVALID_VALUE would generated if access has any bits set other than those valid defined bits. Signed-off-by: Yuanhan Liu --- src/mesa/main/bufferobj.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) di

[Mesa-dev] [PATCH 2/2] mesa: fix error handling for glMapBufferRange

2011-09-19 Thread Yuanhan Liu
Accroding the man page, GL_INVALID_VALUE would generated if access has any bits set other than those valid defined bits. Signed-off-by: Yuanhan Liu --- src/mesa/main/bufferobj.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mes