Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-07 Thread Dave Airlie
>>> >> Getting back on topic... what should I do? :) Check this in with the >> new cap? Or just make it the default behaviour and let drivers that >> can't handle it do the lowering in the driver? FWIW, I believe Dave >> Airlie was against that, but that might have been because he was >> implementi

Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-07 Thread Dave Airlie
On 8 May 2014 04:33, Ilia Mirkin wrote: > On Tue, May 6, 2014 at 1:36 PM, Ilia Mirkin wrote: >> On Tue, May 6, 2014 at 1:29 PM, Roland Scheidegger >> wrote: >>> Am 06.05.2014 17:03, schrieb Ilia Mirkin: On Tue, May 6, 2014 at 10:48 AM, Roland Scheidegger wrote: > Looks good to m

Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-07 Thread Roland Scheidegger
Am 07.05.2014 20:33, schrieb Ilia Mirkin: > On Tue, May 6, 2014 at 1:36 PM, Ilia Mirkin wrote: >> On Tue, May 6, 2014 at 1:29 PM, Roland Scheidegger >> wrote: >>> Am 06.05.2014 17:03, schrieb Ilia Mirkin: On Tue, May 6, 2014 at 10:48 AM, Roland Scheidegger wrote: > Looks good to

Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-07 Thread Ilia Mirkin
On Tue, May 6, 2014 at 1:36 PM, Ilia Mirkin wrote: > On Tue, May 6, 2014 at 1:29 PM, Roland Scheidegger wrote: >> Am 06.05.2014 17:03, schrieb Ilia Mirkin: >>> On Tue, May 6, 2014 at 10:48 AM, Roland Scheidegger >>> wrote: Looks good to me. >>> >>> Thanks! >>> Does that mean if also t

Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-06 Thread Ilia Mirkin
On Tue, May 6, 2014 at 1:29 PM, Roland Scheidegger wrote: > Am 06.05.2014 17:03, schrieb Ilia Mirkin: >> On Tue, May 6, 2014 at 10:48 AM, Roland Scheidegger >> wrote: >>> Looks good to me. >> >> Thanks! >> >>> Does that mean if also the GATHER_SM5 cap is supported you have to >>> support 4 indep

Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-06 Thread Roland Scheidegger
Am 06.05.2014 17:03, schrieb Ilia Mirkin: > On Tue, May 6, 2014 at 10:48 AM, Roland Scheidegger > wrote: >> Looks good to me. > > Thanks! > >> Does that mean if also the GATHER_SM5 cap is supported you have to >> support 4 independent, non-constant offsets? > > Not 100% sure what you're asking

Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-06 Thread Ilia Mirkin
On Tue, May 6, 2014 at 10:48 AM, Roland Scheidegger wrote: > Looks good to me. Thanks! > Does that mean if also the GATHER_SM5 cap is supported you have to > support 4 independent, non-constant offsets? Not 100% sure what you're asking... but yes, for ARB_gs5 to work, you have to support indepe

Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-06 Thread Roland Scheidegger
Looks good to me. Does that mean if also the GATHER_SM5 cap is supported you have to support 4 independent, non-constant offsets? Would it make sense to reorder the caps so the gather stuff is all together (now 5 cap bits just for this...)? Roland Am 29.04.2014 01:30, schrieb Ilia Mirkin: > Signe

Re: [Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-05-06 Thread Ilia Mirkin
ping for this and 1/2 (which just adds the new cap) On Mon, Apr 28, 2014 at 7:30 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > The handling of the 4 offsets is less-than-pretty. I had an alternate version > that created a new ir_dereference_array object and ran ->accept on that.

[Mesa-dev] [PATCH 2/2] mesa/st: pass 4-offset TG4 without lowering if supported

2014-04-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- The handling of the 4 offsets is less-than-pretty. I had an alternate version that created a new ir_dereference_array object and ran ->accept on that. This worked as well, but for each offset it would create a separate new array, and then deref just one item out of