Re: [Mesa-dev] [PATCH 2/2] i965: Don't copy propagate bitcasts with source modifiers.

2013-08-16 Thread Paul Berry
On 15 August 2013 16:19, Matt Turner wrote: > Previously, copy propagation would cause bitcast_f2u(abs(float)) to > be performed in a single step, but the application of source modifiers > (abs, neg) happens after type conversion, leading to incorrect results. > > That is, for bitcast_f2u(abs(flo

[Mesa-dev] [PATCH 2/2] i965: Don't copy propagate bitcasts with source modifiers.

2013-08-15 Thread Matt Turner
Previously, copy propagation would cause bitcast_f2u(abs(float)) to be performed in a single step, but the application of source modifiers (abs, neg) happens after type conversion, leading to incorrect results. That is, for bitcast_f2u(abs(float)) we would in fact generate code to do abs(bitcast_f

Re: [Mesa-dev] [PATCH 2/2] i965: Don't copy propagate bitcasts with source modifiers.

2013-08-15 Thread Paul Berry
On 12 August 2013 13:18, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp| 13 + > src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 3 +++ > src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 10 ++ > 3 files changed, 22 ins

[Mesa-dev] [PATCH 2/2] i965: Don't copy propagate bitcasts with source modifiers.

2013-08-12 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp| 13 + src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 10 ++ 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/mesa/driver