Re: [Mesa-dev] [PATCH 2/2] i965: Don't add base_binding_table_index if it's zero

2015-05-29 Thread Ben Widawsky
On Fri, May 29, 2015 at 02:53:35PM +0100, Neil Roberts wrote: > When calculating the binding table index for non-constant sampler > array indexing it needs to add the base binding table index which is a > constant within the generated code. Often this base is zero so we can > avoid a redundant inst

Re: [Mesa-dev] [PATCH 2/2] i965: Don't add base_binding_table_index if it's zero

2015-05-29 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] i965: Don't add base_binding_table_index if it's zero

2015-05-29 Thread Neil Roberts
When calculating the binding table index for non-constant sampler array indexing it needs to add the base binding table index which is a constant within the generated code. Often this base is zero so we can avoid a redundant instruction in that case. It looks like nothing in shader-db is doing non