Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-24 Thread Emil Velikov
On Fri, 24 Aug 2018 at 15:43, Andres Gomez wrote: > > Emil, I've done some trivial conflicts resolution upon cherry picking > this commit. > > You can see it at (staging/18.2): > https://gitlab.freedesktop.org/mesa/mesa/commit/f6dccf66865c31b13f48b50891a9f5a0d9949b1c > > Please, let me know if thi

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-24 Thread Andres Gomez
Emil, I've done some trivial conflicts resolution upon cherry picking this commit. You can see it at (staging/18.2): https://gitlab.freedesktop.org/mesa/mesa/commit/f6dccf66865c31b13f48b50891a9f5a0d9949b1c Please, let me know if this is OK. On Fri, 2018-08-17 at 12:11 +0100, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-18 Thread Emil Velikov
On 18 August 2018 at 13:02, Eric Engestrom wrote: > On Saturday, 2018-08-18 12:25:42 +0100, Eric Engestrom wrote: >> On Friday, 2018-08-17 10:55:28 -0700, Dylan Baker wrote: >> > I don't care one way or the other on this, but it needs to wait for the >> > series I >> > have to make two of the tes

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-18 Thread Eric Engestrom
On Saturday, 2018-08-18 12:25:42 +0100, Eric Engestrom wrote: > On Friday, 2018-08-17 10:55:28 -0700, Dylan Baker wrote: > > I don't care one way or the other on this, but it needs to wait for the > > series I > > have to make two of the test cases py 3 ready, and for a patch from Mathieu > > to

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-18 Thread Eric Engestrom
On Friday, 2018-08-17 10:55:28 -0700, Dylan Baker wrote: > I don't care one way or the other on this, but it needs to wait for the > series I > have to make two of the test cases py 3 ready, and for a patch from Mathieu to > make another py 3 ready. > > Just for reference, it is convention (thoug

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-18 Thread Emil Velikov
On 17 August 2018 at 18:55, Dylan Baker wrote: > I don't care one way or the other on this, but it needs to wait for the > series I > have to make two of the test cases py 3 ready, and for a patch from Mathieu to > make another py 3 ready. > > Just for reference, it is convention (though I don't

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-17 Thread Dylan Baker
I don't care one way or the other on this, but it needs to wait for the series I have to make two of the test cases py 3 ready, and for a patch from Mathieu to make another py 3 ready. Just for reference, it is convention (though I don't care to keep it) to use such a shebang to mark whether a scr

[Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-17 Thread Emil Velikov
From: Emil Velikov Just like the rest of the tree - these should be run either as part of the build system check target, or at the very least with an explicitly versioned python executable. Cc: Dylan Baker Fixes: db8cd8e3677 ("glcpp/tests: Convert shell scripts to a python script") Fixes: 97c28