Re: [Mesa-dev] [PATCH 2/2] glsl: remove duplicate validation

2017-04-26 Thread Samuel Pitoiset
On 04/26/2017 10:07 AM, Timothy Arceri wrote: On 26/04/17 17:40, Samuel Pitoiset wrote: Nope, I'm pretty sure this allows to declare "out bool foo" in a fragment shader because is_varying_var() only returns TRUE for inputs. The code below what this patch removes validates frag outputs. Tha

Re: [Mesa-dev] [PATCH 2/2] glsl: remove duplicate validation

2017-04-26 Thread Timothy Arceri
On 26/04/17 17:40, Samuel Pitoiset wrote: Nope, I'm pretty sure this allows to declare "out bool foo" in a fragment shader because is_varying_var() only returns TRUE for inputs. The code below what this patch removes validates frag outputs. That should catch your example. On 04/26/2017 0

Re: [Mesa-dev] [PATCH 2/2] glsl: remove duplicate validation

2017-04-26 Thread Samuel Pitoiset
Nope, I'm pretty sure this allows to declare "out bool foo" in a fragment shader because is_varying_var() only returns TRUE for inputs. On 04/26/2017 05:56 AM, Timothy Arceri wrote: Varying types have already been validated in apply_type_qualifier_to_variable() by this point. --- src/compiler

Re: [Mesa-dev] [PATCH 2/2] glsl: remove duplicate validation

2017-04-25 Thread Alejandro PiƱeiro
On 26/04/17 05:56, Timothy Arceri wrote: > Varying types have already been validated in > apply_type_qualifier_to_variable() by this point. After taking a look, it is not so evident (at least to me) that the opaque condition is being tested. In any case, the patch makes sense, so again, assuming n

[Mesa-dev] [PATCH 2/2] glsl: remove duplicate validation

2017-04-25 Thread Timothy Arceri
Varying types have already been validated in apply_type_qualifier_to_variable() by this point. --- src/compiler/glsl/ast_to_hir.cpp | 15 --- 1 file changed, 15 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 0ae87cb..ef6f6cc 100644