Re: [Mesa-dev] [PATCH 2/2] glsl: merge loop_controls.cpp with loop_unroll.cpp

2017-09-20 Thread Thomas Helland
I've only skimmed this, but it looks trivial and correct. This patch series is: Reviewed-by: Thomas Helland I like the idea of getting rid of some of the walks over the IR, and have a set of patches sitting locally doing just that. I think I got most of them reviewed, but then it stalled. I've ju

[Mesa-dev] [PATCH 2/2] glsl: merge loop_controls.cpp with loop_unroll.cpp

2017-09-18 Thread Timothy Arceri
Having this separate just makes the code harder to follow, and requires an extra walk of the IR. --- src/compiler/Makefile.sources| 1 - src/compiler/glsl/glsl_parser_extras.cpp | 1 - src/compiler/glsl/loop_analysis.h| 16 - src/compiler/glsl/loop_controls.cpp |