Re: [Mesa-dev] [PATCH 2/2] glsl: disable array splitting for AoA

2017-06-22 Thread Timothy Arceri
Hi Jason, I think this patch is exposing a bug in nir_opt_copy_prop_vars with AoA. I've tried to figure out what was going on but got a bit lost in that code, any ideas/pointers appreciated. An example of the bug can be seen with: ES31-CTS.functional.shaders.arrays_of_arrays.constructor.impl

[Mesa-dev] [PATCH 2/2] glsl: disable array splitting for AoA

2017-05-24 Thread Timothy Arceri
While it produces functioning code the pass creates worse code for arrays of arrays. See the comment added in this patch for more detail. --- src/compiler/glsl/opt_array_splitting.cpp | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/compiler/glsl/opt_array_splitt