Re: [Mesa-dev] [PATCH 2/2] glsl: Implement a lowering pass for gl_ClipDistance.

2011-09-23 Thread Paul Berry
On 21 September 2011 18:21, Kenneth Graunke wrote: > > Overall, this looks great, Paul. Other than my few small comments: > > Reviewed-by: Kenneth Graunke > Thanks, Ken. I just pushed this to master. Let me know when your ir_call patches land--I don't think they will conflict, but after they

Re: [Mesa-dev] [PATCH 2/2] glsl: Implement a lowering pass for gl_ClipDistance.

2011-09-21 Thread Kenneth Graunke
On 09/15/2011 04:40 PM, Paul Berry wrote: > In i965 GEN6+ (and I suspect most other hardware), gl_ClipDistance > needs to be laid out as a pair of vec4's (the first containing clip > distances 0-3, and the second containing clip distances 4-7). > However, it is declared in GLSL as an array of 8 flo

Re: [Mesa-dev] [PATCH 2/2] glsl: Implement a lowering pass for gl_ClipDistance.

2011-09-21 Thread Eric Anholt
On Mon, 19 Sep 2011 13:40:47 -0700, Paul Berry wrote: Non-text part: multipart/alternative > On 19 September 2011 11:10, Ian Romanick wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 09/15/2011 04:40 PM, Paul Berry wrote: > > > In i965 GEN6+ (and I suspect most other har

Re: [Mesa-dev] [PATCH 2/2] glsl: Implement a lowering pass for gl_ClipDistance.

2011-09-19 Thread Paul Berry
On 19 September 2011 11:10, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/15/2011 04:40 PM, Paul Berry wrote: > > In i965 GEN6+ (and I suspect most other hardware), gl_ClipDistance > > needs to be laid out as a pair of vec4's (the first containing > > clip distan

Re: [Mesa-dev] [PATCH 2/2] glsl: Implement a lowering pass for gl_ClipDistance.

2011-09-19 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/15/2011 04:40 PM, Paul Berry wrote: > In i965 GEN6+ (and I suspect most other hardware), gl_ClipDistance > needs to be laid out as a pair of vec4's (the first containing > clip distances 0-3, and the second containing clip distances 4-7). > How

[Mesa-dev] [PATCH 2/2] glsl: Implement a lowering pass for gl_ClipDistance.

2011-09-15 Thread Paul Berry
In i965 GEN6+ (and I suspect most other hardware), gl_ClipDistance needs to be laid out as a pair of vec4's (the first containing clip distances 0-3, and the second containing clip distances 4-7). However, it is declared in GLSL as an array of 8 floats. This lowering pass acts at the GLSL level, m