Re: [Mesa-dev] [PATCH 2/2] glsl: Fix gl_NormalScale.

2017-11-29 Thread Brian Paul
Reviewed-by: Brian Paul On 11/23/2017 01:48 PM, Fabian Bieler wrote: GLSL shaders can access the normal scale factor with the built-in gl_NormalScale. Mesa's modelspace lighting optimization uses a different normal scale factor than defined in the spec. We have to take care not to use this

[Mesa-dev] [PATCH 2/2] glsl: Fix gl_NormalScale.

2017-11-23 Thread Fabian Bieler
GLSL shaders can access the normal scale factor with the built-in gl_NormalScale. Mesa's modelspace lighting optimization uses a different normal scale factor than defined in the spec. We have to take care not to use this factor for gl_NormalScale. Mesa already defines two seperate states: state