Re: [Mesa-dev] [PATCH 2/2] draw: fix overflows in the indexed rendering paths

2013-07-03 Thread Jose Fonseca
Series looks good AFAICT. Reviewed-by: Jose Fonseca - Original Message - > The semantics for overflow detection are a bit tricky with > indexed rendering. If the base index in the elements array > overflows, then the index of the first element should be used, > if the index with bias ov

Re: [Mesa-dev] [PATCH 2/2] draw: fix overflows in the indexed rendering paths

2013-07-03 Thread Zack Rusin
> On 07/03/2013 02:33 PM, Zack Rusin wrote: > > - Original Message - > >> The code looks good AFAICT. Just a few style nits below. > >> > >> For both: Reviewed-by: Brian Paul > > > > Thanks a lot for the review. > > > > > >>>#define DRAW_GET_IDX(_elts, _i) \ > >>> -

Re: [Mesa-dev] [PATCH 2/2] draw: fix overflows in the indexed rendering paths

2013-07-03 Thread Brian Paul
On 07/03/2013 02:33 PM, Zack Rusin wrote: - Original Message - The code looks good AFAICT. Just a few style nits below. For both: Reviewed-by: Brian Paul Thanks a lot for the review. #define DRAW_GET_IDX(_elts, _i) \ - (((_i) >= draw->pt.user.eltMax) ? 0 :

Re: [Mesa-dev] [PATCH 2/2] draw: fix overflows in the indexed rendering paths

2013-07-03 Thread Roland Scheidegger
Am 03.07.2013 07:42, schrieb Zack Rusin: > The semantics for overflow detection are a bit tricky with > indexed rendering. If the base index in the elements array > overflows, then the index of the first element should be used, > if the index with bias overflows then it should be treated > like a n

Re: [Mesa-dev] [PATCH 2/2] draw: fix overflows in the indexed rendering paths

2013-07-03 Thread Zack Rusin
- Original Message - > The code looks good AFAICT. Just a few style nits below. > > For both: Reviewed-by: Brian Paul Thanks a lot for the review. > > #define DRAW_GET_IDX(_elts, _i) \ > > - (((_i) >= draw->pt.user.eltMax) ? 0 : (_elts)[_i]) > > + (((_i) >= dr

Re: [Mesa-dev] [PATCH 2/2] draw: fix overflows in the indexed rendering paths

2013-07-03 Thread Brian Paul
The code looks good AFAICT. Just a few style nits below. For both: Reviewed-by: Brian Paul On 07/02/2013 11:42 PM, Zack Rusin wrote: The semantics for overflow detection are a bit tricky with indexed rendering. If the base index in the elements array overflows, then the index of the first e

[Mesa-dev] [PATCH 2/2] draw: fix overflows in the indexed rendering paths

2013-07-03 Thread Zack Rusin
The semantics for overflow detection are a bit tricky with indexed rendering. If the base index in the elements array overflows, then the index of the first element should be used, if the index with bias overflows then it should be treated like a normal overflow. Also overflows need to be checked f