Re: [Mesa-dev] [PATCH 2/2] clover: clCompileProgram CL_INVALID_COMPILER_OPTIONS

2014-12-02 Thread Tom Stellard
On Mon, Nov 10, 2014 at 07:04:54PM +0200, Francisco Jerez wrote: > EdB writes: > > > clCompileProgram should return CL_INVALID_COMPILER_OPTIONS > > instead of CL_INVALID_BUILD_OPTIONS > > Looks good to me, > Reviewed-by: Francisco Jerez I've pushed this, thanks! -Tom > > > --- > > src/galli

Re: [Mesa-dev] [PATCH 2/2] clover: clCompileProgram CL_INVALID_COMPILER_OPTIONS

2014-11-29 Thread EdB
On Monday 10 November 2014 19:04:54 Francisco Jerez wrote: > EdB writes: > > clCompileProgram should return CL_INVALID_COMPILER_OPTIONS > > instead of CL_INVALID_BUILD_OPTIONS > > Looks good to me, > Reviewed-by: Francisco Jerez I don't have commit access. Can someone push it for me? > > > --

Re: [Mesa-dev] [PATCH 2/2] clover: clCompileProgram CL_INVALID_COMPILER_OPTIONS

2014-11-10 Thread Francisco Jerez
EdB writes: > clCompileProgram should return CL_INVALID_COMPILER_OPTIONS > instead of CL_INVALID_BUILD_OPTIONS Looks good to me, Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/api/program.cpp | 2 ++ > src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- >

[Mesa-dev] [PATCH 2/2] clover: clCompileProgram CL_INVALID_COMPILER_OPTIONS

2014-11-07 Thread EdB
clCompileProgram should return CL_INVALID_COMPILER_OPTIONS instead of CL_INVALID_BUILD_OPTIONS --- src/gallium/state_trackers/clover/api/program.cpp | 2 ++ src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/s