Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Jason Ekstrand
On Wed, Feb 15, 2017 at 1:54 PM, Chad Versace wrote: > On Wed 15 Feb 2017, Emil Velikov wrote: > > On 14 February 2017 at 21:02, Chad Versace > wrote: > > > On Tue 14 Feb 2017, Kenneth Graunke wrote: > > >> On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > > >> > On Tue 14 Feb

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Chad Versace
On Wed 15 Feb 2017, Emil Velikov wrote: > On 14 February 2017 at 21:02, Chad Versace wrote: > > On Tue 14 Feb 2017, Kenneth Graunke wrote: > >> On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > >> > On Tue 14 Feb 2017, Matt Turner wrote: > >> > > >> > > >> > > static bool > >> >

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Chad Versace
Series is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Emil Velikov
On 15 February 2017 at 19:00, Matt Turner wrote: > On Wed, Feb 15, 2017 at 6:05 AM, Emil Velikov > wrote: >> Hi Matt, >> >> On 14 February 2017 at 23:58, Matt Turner wrote: >>> The --build-id=... ld flag has been present since binutils-2.18, >>> released 28 Aug 2007. >>> --- >>> src/intel/vulk

[Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Matt Turner
The --build-id=... ld flag has been present since binutils-2.18, released 28 Aug 2007. --- src/intel/vulkan/Makefile.am | 1 + src/intel/vulkan/anv_device.c | 28 +++- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Thanks for getting this figured out! On Tue, Feb 14, 2017 at 3:58 PM, Matt Turner wrote: > The --build-id=... ld flag has been present since binutils-2.18, > released 28 Aug 2007. > --- > src/intel/vulkan/Makefile.am | 1 + > src/intel/vulkan/anv_device.c | 28 ++

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Matt Turner
On Wed, Feb 15, 2017 at 6:05 AM, Emil Velikov wrote: > Hi Matt, > > On 14 February 2017 at 23:58, Matt Turner wrote: >> The --build-id=... ld flag has been present since binutils-2.18, >> released 28 Aug 2007. >> --- >> src/intel/vulkan/Makefile.am | 1 + >> src/intel/vulkan/anv_device.c | 28

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Emil Velikov
Hi Matt, On 14 February 2017 at 23:58, Matt Turner wrote: > The --build-id=... ld flag has been present since binutils-2.18, > released 28 Aug 2007. > --- > src/intel/vulkan/Makefile.am | 1 + > src/intel/vulkan/anv_device.c | 28 +++- > 2 files changed, 8 insertions(+)

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Emil Velikov
On 14 February 2017 at 21:02, Chad Versace wrote: > On Tue 14 Feb 2017, Kenneth Graunke wrote: >> On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: >> > On Tue 14 Feb 2017, Matt Turner wrote: >> > >> > >> > > static bool >> > > -anv_get_function_timestamp(void *ptr, uint32_t* time

[Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-14 Thread Matt Turner
The --build-id=... ld flag has been present since binutils-2.18, released 28 Aug 2007. --- src/intel/vulkan/Makefile.am | 1 + src/intel/vulkan/anv_device.c | 28 +++- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-14 Thread Chad Versace
On Tue 14 Feb 2017, Kenneth Graunke wrote: > On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > > On Tue 14 Feb 2017, Matt Turner wrote: > > > > > > > static bool > > > -anv_get_function_timestamp(void *ptr, uint32_t* timestamp) > > > +anv_device_get_cache_uuid(void *uuid) > > >

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-14 Thread Kenneth Graunke
On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > On Tue 14 Feb 2017, Matt Turner wrote: > > > > static bool > > -anv_get_function_timestamp(void *ptr, uint32_t* timestamp) > > +anv_device_get_cache_uuid(void *uuid) > > { > > - Dl_info info; > > - struct stat st; > > - i

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-14 Thread Chad Versace
On Tue 14 Feb 2017, Matt Turner wrote: > static bool > -anv_get_function_timestamp(void *ptr, uint32_t* timestamp) > +anv_device_get_cache_uuid(void *uuid) > { > - Dl_info info; > - struct stat st; > - if (!dladdr(ptr, &info) || !info.dli_fname) > + const struct note *note = build_id_fi

[Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-14 Thread Matt Turner
The --build-id=... ld flag has been present since binutils-2.18, released 28 Aug 2007. --- src/intel/vulkan/Makefile.am | 1 + src/intel/vulkan/anv_device.c | 31 --- 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/i