Re: [Mesa-dev] [PATCH 2/2] Remove fs-discard-exit-3

2016-04-08 Thread Marek Olšák
BTW, Talos Principle had a bug that it calculated derivatives after discard, which is undefined on radeonsi if it results in non-uniform control flow. Then, somebody reported the bug to them, and they fixed it. I have to say that rarely do we find a test that quotes the spec and expects the exact

Re: [Mesa-dev] [PATCH 2/2] Remove fs-discard-exit-3

2016-04-08 Thread Francisco Jerez
Marek Olšák writes: > From: Marek Olšák > > The test is wrong and the GLSL 1.30 citation in the test states very > clearly that discard can cause non-uniform control flow for any code that > follows. Heh, IIRC I sent this exact same patch over a year ago but I didn't get particularly enthusiast

[Mesa-dev] [PATCH 2/2] Remove fs-discard-exit-3

2016-04-08 Thread Marek Olšák
From: Marek Olšák The test is wrong and the GLSL 1.30 citation in the test states very clearly that discard can cause non-uniform control flow for any code that follows. --- .../execution/fs-discard-exit-3.shader_test| 76 -- 1 file changed, 76 deletions(-) delete mo