Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-12 Thread Jose Fonseca
- Original Message - > On Thu, Oct 11, 2012 at 2:04 PM, Jose Fonseca > wrote: > > - Original Message - > >> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run > >> swrast. > >> This is not what people expect. > >> --- > >> Please check my logic. The Apple code checks th

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-12 Thread Jose Fonseca
- Original Message - > On Thu, Oct 11, 2012 at 8:53 PM, Matt Turner > wrote: > > On Thu, Oct 11, 2012 at 2:12 PM, Dave Airlie > > wrote: > >>> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run > >>> swrast. > >>> This is not what people expect. > >> > >> Is it documented eith

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-11 Thread Matt Turner
On Thu, Oct 11, 2012 at 6:08 PM, Dave Airlie wrote: > On Thu, Oct 11, 2012 at 8:53 PM, Matt Turner wrote: >> On Thu, Oct 11, 2012 at 2:12 PM, Dave Airlie wrote: Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run swrast. This is not what people expect. >>> >>> Is it documented

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-11 Thread Dave Airlie
On Thu, Oct 11, 2012 at 8:53 PM, Matt Turner wrote: > On Thu, Oct 11, 2012 at 2:12 PM, Dave Airlie wrote: >>> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run swrast. >>> This is not what people expect. >> >> Is it documented either way, its kinda like ifdef vs if in C, I >> generally

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-11 Thread Matt Turner
On Thu, Oct 11, 2012 at 2:12 PM, Dave Airlie wrote: >> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run swrast. >> This is not what people expect. > > Is it documented either way, its kinda like ifdef vs if in C, I > generally for this sort of thing except ifdef behaviour. > > Dave. e

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-11 Thread Matt Turner
On Thu, Oct 11, 2012 at 2:04 PM, Jose Fonseca wrote: > - Original Message - >> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run swrast. >> This is not what people expect. >> --- >> Please check my logic. The Apple code checks the opposite (whether we >> want software/indirect)

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-11 Thread Dave Airlie
> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run swrast. > This is not what people expect. Is it documented either way, its kinda like ifdef vs if in C, I generally for this sort of thing except ifdef behaviour. Dave. ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-11 Thread Jose Fonseca
- Original Message - > Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run swrast. > This is not what people expect. > --- > Please check my logic. The Apple code checks the opposite (whether we > want software/indirect) whereas the other code checks if we have > acceleration. > >

[Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-11 Thread Matt Turner
Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run swrast. This is not what people expect. --- Please check my logic. The Apple code checks the opposite (whether we want software/indirect) whereas the other code checks if we have acceleration. src/egl/drivers/dri2/platform_x11.c |4