Re: [Mesa-dev] [PATCH 19/78] nir/nir_lower_io: Add vec4 support

2015-07-05 Thread Jason Ekstrand
On Fri, Jul 3, 2015 at 12:58 AM, Iago Toral wrote: > On Thu, 2015-07-02 at 09:31 +0200, Iago Toral wrote: >> On Tue, 2015-06-30 at 11:32 -0700, Jason Ekstrand wrote: >> > I'm not sure what I think about adding an is_scalar flag vs. having >> > _scalar and _vec4 versions of each function. My feeli

Re: [Mesa-dev] [PATCH 19/78] nir/nir_lower_io: Add vec4 support

2015-07-03 Thread Iago Toral
On Thu, 2015-07-02 at 09:31 +0200, Iago Toral wrote: > On Tue, 2015-06-30 at 11:32 -0700, Jason Ekstrand wrote: > > I'm not sure what I think about adding an is_scalar flag vs. having > > _scalar and _vec4 versions of each function. My feeling is that once > > we tweak assign_var_locations as I me

Re: [Mesa-dev] [PATCH 19/78] nir/nir_lower_io: Add vec4 support

2015-07-02 Thread Iago Toral
On Tue, 2015-06-30 at 11:32 -0700, Jason Ekstrand wrote: > I'm not sure what I think about adding an is_scalar flag vs. having > _scalar and _vec4 versions of each function. My feeling is that once > we tweak assign_var_locations as I mentioned for vec4 outputs, we'll > find that we want to have t

Re: [Mesa-dev] [PATCH 19/78] nir/nir_lower_io: Add vec4 support

2015-06-30 Thread Jason Ekstrand
I'm not sure what I think about adding an is_scalar flag vs. having _scalar and _vec4 versions of each function. My feeling is that once we tweak assign_var_locations as I mentioned for vec4 outputs, we'll find that we want to have them separate. The big thing here is that I'd rather have _vec4 a

[Mesa-dev] [PATCH 19/78] nir/nir_lower_io: Add vec4 support

2015-06-26 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga The current implementation operates in scalar mode only, so add a vec4 mode where types are padded to vec4 sizes. This will be useful in the i965 driver for its vec4 nir backend (and possbly other drivers that have vec4-based shaders). Bugzilla: https://bugs.freedesktop