Re: [Mesa-dev] [PATCH 18/18] nir/spirv: Rework function argument setup

2017-07-01 Thread Jason Ekstrand
On Fri, Jun 30, 2017 at 4:31 PM, Connor Abbott wrote: > On Fri, Jun 30, 2017 at 4:25 PM, Jason Ekstrand > wrote: > > On June 30, 2017 3:28:51 PM Connor Abbott wrote: > > > >> Now, that we're handling the pointers explicitly, can't we delete the > >> code in vtn_ssa_value() > >> to implicitly lo

Re: [Mesa-dev] [PATCH 18/18] nir/spirv: Rework function argument setup

2017-06-30 Thread Connor Abbott
On Fri, Jun 30, 2017 at 4:25 PM, Jason Ekstrand wrote: > On June 30, 2017 3:28:51 PM Connor Abbott wrote: > >> Now, that we're handling the pointers explicitly, can't we delete the >> code in vtn_ssa_value() >> to implicitly load pointers? I'd expect to see that in this patch. > > > Almost. It's

Re: [Mesa-dev] [PATCH 18/18] nir/spirv: Rework function argument setup

2017-06-30 Thread Jason Ekstrand
On June 30, 2017 3:28:51 PM Connor Abbott wrote: Now, that we're handling the pointers explicitly, can't we delete the code in vtn_ssa_value() to implicitly load pointers? I'd expect to see that in this patch. Almost. It's still used to implement some glsl.450 functions which take a variabl

Re: [Mesa-dev] [PATCH 18/18] nir/spirv: Rework function argument setup

2017-06-30 Thread Connor Abbott
Now, that we're handling the pointers explicitly, can't we delete the code in vtn_ssa_value() to implicitly load pointers? I'd expect to see that in this patch. On Thu, Jun 29, 2017 at 10:33 AM, Jason Ekstrand wrote: > Now that we have proper pointer types, we can be more sensible about the > way

[Mesa-dev] [PATCH 18/18] nir/spirv: Rework function argument setup

2017-06-29 Thread Jason Ekstrand
Now that we have proper pointer types, we can be more sensible about the way we set up function arguments and deal with the two cases of pointer vs. SSA parameters distinctly. --- src/compiler/spirv/vtn_cfg.c | 62 +--- 1 file changed, 35 insertions(+), 27 d