Re: [Mesa-dev] [PATCH 17/41] glapi: replace RuntimeError with asserts or Exception

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 15:07:09) > On 03/31/2016 05:04 PM, Dylan Baker wrote: > > RuntimeError is a very specific type of error. In almost very case it's > > being raised where an assert is the right choice, and in the rest using > > a plain Exception is better, at least there it's obviou

Re: [Mesa-dev] [PATCH 17/41] glapi: replace RuntimeError with asserts or Exception

2016-04-19 Thread Ian Romanick
On 03/31/2016 05:04 PM, Dylan Baker wrote: > RuntimeError is a very specific type of error. In almost very case it's > being raised where an assert is the right choice, and in the rest using > a plain Exception is better, at least there it's obvious it's not that > the python runtime hit an interna

[Mesa-dev] [PATCH 17/41] glapi: replace RuntimeError with asserts or Exception

2016-03-31 Thread Dylan Baker
RuntimeError is a very specific type of error. In almost very case it's being raised where an assert is the right choice, and in the rest using a plain Exception is better, at least there it's obvious it's not that the python runtime hit an internal error and died. Signed-off-by: Dylan Baker ---