Re: [Mesa-dev] [PATCH 17/17] glsl: Don't monkey about with the interpolation modes

2016-08-24 Thread Timothy Arceri
On Thu, 2016-08-25 at 10:00 +1000, Timothy Arceri wrote: > On Wed, 2016-08-24 at 15:12 -0700, Ian Romanick wrote: > > > > From: Ian Romanick > > > > Previously we'd munge the interpolation mode so that later checks > > in > > the > > GLSL linker would pass.  The caused problems for similar check

Re: [Mesa-dev] [PATCH 17/17] glsl: Don't monkey about with the interpolation modes

2016-08-24 Thread Kenneth Graunke
On Wednesday, August 24, 2016 3:12:43 PM PDT Ian Romanick wrote: > From: Ian Romanick > > Previously we'd munge the interpolation mode so that later checks in the > GLSL linker would pass. The caused problems for similar checks in SSO > IO validation. Instead, make the check smarter, use the sa

Re: [Mesa-dev] [PATCH 17/17] glsl: Don't monkey about with the interpolation modes

2016-08-24 Thread Timothy Arceri
On Wed, 2016-08-24 at 15:12 -0700, Ian Romanick wrote: > From: Ian Romanick > > Previously we'd munge the interpolation mode so that later checks in > the > GLSL linker would pass.  The caused problems for similar checks in > SSO > IO validation.  Instead, make the check smarter, use the same che

[Mesa-dev] [PATCH 17/17] glsl: Don't monkey about with the interpolation modes

2016-08-24 Thread Ian Romanick
From: Ian Romanick Previously we'd munge the interpolation mode so that later checks in the GLSL linker would pass. The caused problems for similar checks in SSO IO validation. Instead, make the check smarter, use the same check in both places, and don't modify the interpolation mode. Fixes pi