Re: [Mesa-dev] [PATCH 16/53] st/nine: Rework of boolean constants

2015-01-07 Thread Ilia Mirkin
On Wed, Jan 7, 2015 at 5:24 PM, Axel Davy wrote: > On 07/01/2015 18:23, Ilia Mirkin wrote : >> >> On Wed, Jan 7, 2015 at 11:36 AM, Axel Davy wrote: >>> >>> Convert them to shader booleans at earlier stage >> >> Why? What's wrong with the conversion as it is now? > > The conversion is fine for boo

Re: [Mesa-dev] [PATCH 16/53] st/nine: Rework of boolean constants

2015-01-07 Thread Axel Davy
On 07/01/2015 18:23, Ilia Mirkin wrote : On Wed, Jan 7, 2015 at 11:36 AM, Axel Davy wrote: Convert them to shader booleans at earlier stage Why? What's wrong with the conversion as it is now? The conversion is fine for booleans, but not for integers. I think it is cleaner to have both boolean

Re: [Mesa-dev] [PATCH 16/53] st/nine: Rework of boolean constants

2015-01-07 Thread Ilia Mirkin
On Wed, Jan 7, 2015 at 11:36 AM, Axel Davy wrote: > Convert them to shader booleans at earlier stage Why? What's wrong with the conversion as it is now? > > Signed-off-by: Axel Davy > > Cc: "10.4" > --- > src/gallium/state_trackers/nine/device9.c| 35 > +--- > src

[Mesa-dev] [PATCH 16/53] st/nine: Rework of boolean constants

2015-01-07 Thread Axel Davy
Convert them to shader booleans at earlier stage Signed-off-by: Axel Davy Cc: "10.4" --- src/gallium/state_trackers/nine/device9.c| 35 +--- src/gallium/state_trackers/nine/device9.h| 6 ++--- src/gallium/state_trackers/nine/nine_state.c | 13 +++ 3 fil