Re: [Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-19 Thread Nicolai Hähnle
On 19.02.2016 06:39, Marek Olšák wrote: On Tue, Feb 16, 2016 at 5:31 PM, Nicolai Hähnle wrote: So, patches 12-16 also look good to me except for the comments I've sent on 12-14. Does this mean I can add your Rb on those? Yes indeed. Nicolai Marek __

Re: [Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-19 Thread Marek Olšák
On Tue, Feb 16, 2016 at 5:31 PM, Nicolai Hähnle wrote: > So, patches 12-16 also look good to me except for the comments I've sent on > 12-14. Does this mean I can add your Rb on those? Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-16 Thread Marek Olšák
On Tue, Feb 16, 2016 at 5:31 PM, Nicolai Hähnle wrote: > So, patches 12-16 also look good to me except for the comments I've sent on > 12-14. > > I'm a bit worried though that there is a lot of "almost code duplication" > around the handling of input and output positions etc., and maintaining the

Re: [Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-16 Thread Nicolai Hähnle
So, patches 12-16 also look good to me except for the comments I've sent on 12-14. I'm a bit worried though that there is a lot of "almost code duplication" around the handling of input and output positions etc., and maintaining the two different code paths for monolithic and non-monolithic i

[Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-15 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.c| 324 +++- src/gallium/drivers/radeonsi/si_shader.h| 14 +- src/gallium/drivers/ra