Re: [Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

2017-01-30 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 30.01.2017 12:54, Marek Olšák wrote: From: Marek Olšák The update frequency is very low. Difference: Only account for the size when allocating a new one and when starting a new IB, and check for NULL. (v3) --- src/gallium/drivers/radeonsi/si_cp_dma

[Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

2017-01-30 Thread Marek Olšák
From: Marek Olšák The update frequency is very low. Difference: Only account for the size when allocating a new one and when starting a new IB, and check for NULL. (v3) --- src/gallium/drivers/radeonsi/si_cp_dma.c| 3 ++- src/gallium/drivers/radeonsi/si_hw_context.c| 7

[Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

2017-01-30 Thread Marek Olšák
From: Marek Olšák The update frequency is very low. Difference: Only account for the size when allocating a new one and when starting a new IB. (v2) --- src/gallium/drivers/radeonsi/si_cp_dma.c| 3 ++- src/gallium/drivers/radeonsi/si_hw_context.c| 5 - src/gallium/

Re: [Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

2017-01-30 Thread Marek Olšák
On Mon, Jan 30, 2017 at 11:01 AM, Nicolai Hähnle wrote: > On 26.01.2017 17:04, Marek Olšák wrote: >> >> From: Marek Olšák >> >> The update frequency is very low. >> >> Difference: Only account for the size when allocating a new one. > > > Why not in the atom emit? With this patch, the size is onl

Re: [Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

2017-01-30 Thread Nicolai Hähnle
On 26.01.2017 17:04, Marek Olšák wrote: From: Marek Olšák The update frequency is very low. Difference: Only account for the size when allocating a new one. Why not in the atom emit? With this patch, the size is only accounted for in the first CS. Nicolai --- src/gallium/drivers/radeon

[Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

2017-01-26 Thread Marek Olšák
From: Marek Olšák The update frequency is very low. Difference: Only account for the size when allocating a new one. --- src/gallium/drivers/radeonsi/si_cp_dma.c| 3 ++- src/gallium/drivers/radeonsi/si_hw_context.c| 2 +- src/gallium/drivers/radeonsi/si_pipe.h | 2 +- sr