Re: [Mesa-dev] [PATCH 153/133] nir/tex_instr: Add a nir_tex_src struct and

2015-01-09 Thread Jason Ekstrand
On Fri, Jan 9, 2015 at 8:24 PM, Connor Abbott wrote: > On Fri, Jan 9, 2015 at 11:04 PM, Jason Ekstrand > wrote: > > This solves a number of problems. First is the ability to change the > > number of sources that a texture instruction has. Second, it solves the > > delema that may occur if a te

Re: [Mesa-dev] [PATCH 153/133] nir/tex_instr: Add a nir_tex_src struct and

2015-01-09 Thread Connor Abbott
On Fri, Jan 9, 2015 at 11:04 PM, Jason Ekstrand wrote: > This solves a number of problems. First is the ability to change the > number of sources that a texture instruction has. Second, it solves the > delema that may occur if a texture instruction has more than 4 sources. > --- > src/glsl/nir/

Re: [Mesa-dev] [PATCH 153/133] nir/tex_instr: Add a nir_tex_src struct and

2015-01-09 Thread Connor Abbott
Ok, with the assert removed, Reviewed-by: Connor Abbott On Fri, Jan 9, 2015 at 11:16 PM, Jason Ekstrand wrote: > > > On Fri, Jan 9, 2015 at 8:04 PM, Jason Ekstrand wrote: >> >> This solves a number of problems. First is the ability to change the >> number of sources that a texture instruction

Re: [Mesa-dev] [PATCH 153/133] nir/tex_instr: Add a nir_tex_src struct and

2015-01-09 Thread Jason Ekstrand
On Fri, Jan 9, 2015 at 8:04 PM, Jason Ekstrand wrote: > This solves a number of problems. First is the ability to change the > number of sources that a texture instruction has. Second, it solves the > delema that may occur if a texture instruction has more than 4 sources. > --- > src/glsl/nir/

[Mesa-dev] [PATCH 153/133] nir/tex_instr: Add a nir_tex_src struct and

2015-01-09 Thread Jason Ekstrand
This solves a number of problems. First is the ability to change the number of sources that a texture instruction has. Second, it solves the delema that may occur if a texture instruction has more than 4 sources. --- src/glsl/nir/glsl_to_nir.cpp | 36