Re: [Mesa-dev] [PATCH 14/14] glsl: Add support for C-style initializers.

2013-07-12 Thread Matt Turner
On Thu, Jul 11, 2013 at 8:52 PM, Matt Turner wrote: >> I believe that all this grammar is correct, but do we have tests for >> spurious curly braces? Things like >> >> vec4 v = {{{1, 2, 3, 4}}}; > > No, I'll write one. Nice call on this test. For vectors _mesa_ast_set_aggregate_type would wa

Re: [Mesa-dev] [PATCH 14/14] glsl: Add support for C-style initializers.

2013-07-11 Thread Matt Turner
On Thu, Jul 11, 2013 at 4:10 PM, Ian Romanick wrote: > On 07/03/2013 01:59 PM, Matt Turner wrote: >> >> Required by GL_ARB_shading_language_420pack. >> >> Parts based on work done by Todd Previte and Ken Graunke, implementing >> basic support for C-style initializers of arrays. >> --- >> src/gls

Re: [Mesa-dev] [PATCH 14/14] glsl: Add support for C-style initializers.

2013-07-11 Thread Ian Romanick
On 07/03/2013 01:59 PM, Matt Turner wrote: Required by GL_ARB_shading_language_420pack. Parts based on work done by Todd Previte and Ken Graunke, implementing basic support for C-style initializers of arrays. --- src/glsl/ast.h | 5 ++ src/glsl/ast_to_hir.cpp | 14

[Mesa-dev] [PATCH 14/14] glsl: Add support for C-style initializers.

2013-07-03 Thread Matt Turner
Required by GL_ARB_shading_language_420pack. Parts based on work done by Todd Previte and Ken Graunke, implementing basic support for C-style initializers of arrays. --- src/glsl/ast.h | 5 ++ src/glsl/ast_to_hir.cpp | 14 +++- src/glsl/glsl_parser.yy | 57 +++

[Mesa-dev] [PATCH 14/14] glsl: Add support for C-style initializers.

2013-06-29 Thread Matt Turner
Required by GL_ARB_shading_language_420pack. Parts based on work done by Todd Previte and Ken Graunke, implementing basic support for C-style initializers of arrays. --- src/glsl/ast.h | 5 ++ src/glsl/ast_to_hir.cpp | 14 +++- src/glsl/glsl_parser.yy | 63 +++