Re: [Mesa-dev] [PATCH 14/14] egl: Implement EGL_KHR_debug

2016-09-13 Thread Emil Velikov
On 13 September 2016 at 18:55, Adam Jackson wrote: > On Tue, 2016-09-13 at 17:17 +0100, Emil Velikov wrote: > >> > + } else { >> > + _eglDebugReportFull(EGL_BAD_ALLOC, __func__, __func__, >> > + EGL_DEBUG_MSG_CRITICAL_KHR, NULL, NULL); >> > + return EGL_BAD_ALLOC

[Mesa-dev] [PATCH 14/14] egl: Implement EGL_KHR_debug (v2)

2016-09-13 Thread Adam Jackson
From: Kyle Brenneman Wire up the debug entrypoints to EGL dispatch, and add the extension string to the client extension list. v2: - Lots of style fixes - Fix missing EGLAPIENTRYs - Factor out valid attribute check - Lock display in eglLabelObjectKHR as needed, and use RETURN_EGL_* - Move "EGL_K

Re: [Mesa-dev] [PATCH 14/14] egl: Implement EGL_KHR_debug

2016-09-13 Thread Adam Jackson
On Tue, 2016-09-13 at 17:17 +0100, Emil Velikov wrote: > > +  } else { > > + _eglDebugReportFull(EGL_BAD_ALLOC, __func__, __func__, > > +   EGL_DEBUG_MSG_CRITICAL_KHR, NULL, NULL); > > + return EGL_BAD_ALLOC; > > +  } > > Nit: Please use the same style as the "

Re: [Mesa-dev] [PATCH 14/14] egl: Implement EGL_KHR_debug

2016-09-13 Thread Kyle Brenneman
On 09/13/2016 10:17 AM, Emil Velikov wrote: Hi guys, There's a bunch of outstanding style nitpicks (come to think of it 13/14 could use the same) Those aside: there's a bunch of serious suggestions which I missed last time. On 12 September 2016 at 23:19, Adam Jackson wrote: From: Kyle Brenne

Re: [Mesa-dev] [PATCH 14/14] egl: Implement EGL_KHR_debug

2016-09-13 Thread Emil Velikov
Hi guys, There's a bunch of outstanding style nitpicks (come to think of it 13/14 could use the same) Those aside: there's a bunch of serious suggestions which I missed last time. On 12 September 2016 at 23:19, Adam Jackson wrote: > From: Kyle Brenneman > > Wire up the debug entrypoints to EGL

[Mesa-dev] [PATCH 14/14] egl: Implement EGL_KHR_debug

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman Wire up the debug entrypoints to EGL dispatch, and add the extension string to the client extension list. --- src/egl/main/eglapi.c | 140 ++ src/egl/main/eglglobals.c | 3 +- 2 files changed, 142 insertions(+), 1 deletion(-)