Re: [Mesa-dev] [PATCH 12/13] mesa: Remove unnecessary locking from container objects.

2015-08-07 Thread Ian Romanick
On 08/07/2015 09:50 AM, Fredrik Höglund wrote: > On Friday 07 August 2015, Matt Turner wrote: >> "Container objects" like vertex array objects, framebuffer objects, and >> pipeline objects are not shared between contexts, so they require no >> locking. > > Unfortunately it's not quite that simple

Re: [Mesa-dev] [PATCH 12/13] mesa: Remove unnecessary locking from container objects.

2015-08-07 Thread Ian Romanick
On 08/06/2015 05:11 PM, Matt Turner wrote: > "Container objects" like vertex array objects, framebuffer objects, and > pipeline objects are not shared between contexts, so they require no > locking. Yes and no. FBOs from EXT_framebuffer_object and VAOs from APPLE_vertex_array_object are shared be

Re: [Mesa-dev] [PATCH 12/13] mesa: Remove unnecessary locking from container objects.

2015-08-07 Thread Fredrik Höglund
On Friday 07 August 2015, Matt Turner wrote: > "Container objects" like vertex array objects, framebuffer objects, and > pipeline objects are not shared between contexts, so they require no > locking. Unfortunately it's not quite that simple when it comes to FBO's; EXT_framebuffer_object defines F

Re: [Mesa-dev] [PATCH 12/13] mesa: Remove unnecessary locking from container objects.

2015-08-07 Thread Brian Paul
On 08/06/2015 06:11 PM, Matt Turner wrote: "Container objects" like vertex array objects, framebuffer objects, and pipeline objects are not shared between contexts, so they require no locking. Framebuffer/renderbuffer objects _are_ shared among contexts. Note that _mesa_lookup_framebuffer() a

[Mesa-dev] [PATCH 12/13] mesa: Remove unnecessary locking from container objects.

2015-08-06 Thread Matt Turner
"Container objects" like vertex array objects, framebuffer objects, and pipeline objects are not shared between contexts, so they require no locking. --- src/mesa/main/arrayobj.c| 6 -- src/mesa/main/fbobject.c| 9 - src/mesa/main/framebuffer.c | 9 - src/mesa/main/mtyp