Re: [Mesa-dev] [PATCH 119/133] nir: Rework the way samplers are lowered

2015-01-06 Thread Chris Forbes
Looks reasonable to me. Reviewed-by: Chris Forbes On Tue, Dec 16, 2014 at 7:13 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_lower_samplers.cpp | 149 > ++-- > 1 file changed, 74 insertions(+), 75 deletions(-) > > diff --git a/src/glsl/nir/nir_lower_sample

Re: [Mesa-dev] [PATCH 119/133] nir: Rework the way samplers are lowered

2015-01-05 Thread Connor Abbott
I don't really feel qualified to review this, since I didn't write any of the original code (I just copied-n-pasted it from what i965 was doing...). I'm not sure who would be able to, maybe Chris Forbes since he did the indirect sampler work? On Tue, Dec 16, 2014 at 1:13 AM, Jason Ekstrand wrote:

[Mesa-dev] [PATCH 119/133] nir: Rework the way samplers are lowered

2014-12-15 Thread Jason Ekstrand
--- src/glsl/nir/nir_lower_samplers.cpp | 149 ++-- 1 file changed, 74 insertions(+), 75 deletions(-) diff --git a/src/glsl/nir/nir_lower_samplers.cpp b/src/glsl/nir/nir_lower_samplers.cpp index d94183c..ece4dc3 100644 --- a/src/glsl/nir/nir_lower_samplers.cpp +++