Re: [Mesa-dev] [PATCH 118/133] nir: Add a sampler index indirect to nir_tex_instr

2015-01-07 Thread Jason Ekstrand
On Wed, Jan 7, 2015 at 9:58 AM, Jason Ekstrand wrote: > > > On Wed, Jan 7, 2015 at 7:55 AM, Connor Abbott wrote: > >> On Tue, Jan 6, 2015 at 6:36 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Mon, Jan 5, 2015 at 10:45 PM, Connor Abbott >> wrote: >> >> >> >> I created nir_tex_src_sampler_index

Re: [Mesa-dev] [PATCH 118/133] nir: Add a sampler index indirect to nir_tex_instr

2015-01-07 Thread Jason Ekstrand
On Wed, Jan 7, 2015 at 7:55 AM, Connor Abbott wrote: > On Tue, Jan 6, 2015 at 6:36 PM, Jason Ekstrand > wrote: > > > > > > On Mon, Jan 5, 2015 at 10:45 PM, Connor Abbott > wrote: > >> > >> I created nir_tex_src_sampler_index for exactly this purpose, which > >> fits in with the "stick all the s

Re: [Mesa-dev] [PATCH 118/133] nir: Add a sampler index indirect to nir_tex_instr

2015-01-07 Thread Connor Abbott
On Tue, Jan 6, 2015 at 6:36 PM, Jason Ekstrand wrote: > > > On Mon, Jan 5, 2015 at 10:45 PM, Connor Abbott wrote: >> >> I created nir_tex_src_sampler_index for exactly this purpose, which >> fits in with the "stick all the sources in an array so we can easily >> iterate over them" philosophy. If

Re: [Mesa-dev] [PATCH 118/133] nir: Add a sampler index indirect to nir_tex_instr

2015-01-06 Thread Jason Ekstrand
On Mon, Jan 5, 2015 at 10:45 PM, Connor Abbott wrote: > I created nir_tex_src_sampler_index for exactly this purpose, which > fits in with the "stick all the sources in an array so we can easily > iterate over them" philosophy. If you decide to keep with this > solution, though, at least remove t

Re: [Mesa-dev] [PATCH 118/133] nir: Add a sampler index indirect to nir_tex_instr

2015-01-05 Thread Connor Abbott
I created nir_tex_src_sampler_index for exactly this purpose, which fits in with the "stick all the sources in an array so we can easily iterate over them" philosophy. If you decide to keep with this solution, though, at least remove that. On Tue, Dec 16, 2014 at 1:13 AM, Jason Ekstrand wrote: >

[Mesa-dev] [PATCH 118/133] nir: Add a sampler index indirect to nir_tex_instr

2014-12-15 Thread Jason Ekstrand
--- src/glsl/nir/nir.c | 11 +++ src/glsl/nir/nir.h | 10 ++ src/glsl/nir/nir_print.c| 4 src/glsl/nir/nir_validate.c | 3 +++ 4 files changed, 28 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 60c9cff..8bcc64a 100644 --- a/sr