Re: [Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2015-01-05 Thread Laura Ekstrand
These comments have been addressed: http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=a2f20c936f6db31986220938db06cf28885e7ee6 . Thanks. Laura On Wed, Dec 31, 2014 at 6:03 PM, Anuj Phogat wrote: > On Tue, Dec 16, 2014 at 10:59 AM, Laura Ekstrand > wrote: > > This happens almo

Re: [Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2014-12-31 Thread Anuj Phogat
On Tue, Dec 16, 2014 at 10:59 AM, Laura Ekstrand wrote: > This happens almost everywhere. I prefer to call _mesa_error(ctx, > "glTex%sStorage" rather than _mesa_error(ctx, "%s" because it's > more obvious when reading the code which API function you're in (texture > storage rather than c

Re: [Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2014-12-16 Thread Laura Ekstrand
This happens almost everywhere. I prefer to call _mesa_error(ctx, "glTex%sStorage" rather than _mesa_error(ctx, "%s" because it's more obvious when reading the code which API function you're in (texture storage rather than copy texture sub image, etc). Would this work better? const char

Re: [Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 24 +++ src/mesa/main/texstorage.c | 205 +++-- src/mesa/main/texstorage.h | 31 3 files changed, 209 insertions(+), 51 deleti

[Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 24 +++ src/mesa/main/texstorage.c | 205 +++-- src/mesa/main/texstorage.h | 31 3 files changed, 209 insertions(+), 51 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_s