Re: [Mesa-dev] [PATCH 11/38] main: Major refactor of get_texture_for_framebuffer.

2015-04-28 Thread Fredrik Höglund
On Sunday 12 April 2015, Fredrik Höglund wrote: > This looks like a very nice cleanup indeed! > > One thing I noticed though is that fbobject.c seems to use two blank > lines between function definitions, although it's not consistent about it. > The functions introduced in this patch only have one

Re: [Mesa-dev] [PATCH 11/38] main: Major refactor of get_texture_for_framebuffer.

2015-04-12 Thread Fredrik Höglund
This looks like a very nice cleanup indeed! One thing I noticed though is that fbobject.c seems to use two blank lines between function definitions, although it's not consistent about it. The functions introduced in this patch only have one blank line between them. Some more comments (mostly nitp

[Mesa-dev] [PATCH 11/38] main: Major refactor of get_texture_for_framebuffer.

2015-03-03 Thread Laura Ekstrand
This splits off the (still) rather large chunk that is get_texture_for_framebuffer into lots of smaller functions specialized to service the wide variety of unique needs of *FramebufferTexture* entry points. The result is much cleaner because, rather than having a pile of branches and confusing con