Re: [Mesa-dev] [PATCH 11/20] anv/pipeline: Unify 3DSTATE_PS emission

2016-11-14 Thread Jason Ekstrand
On Mon, Nov 14, 2016 at 2:35 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote: > > In this patch we no longer do: > > ps.RenderTargetResolveEnable = false; > > It would be nice to be consistent and either initialise everything or

Re: [Mesa-dev] [PATCH 11/20] anv/pipeline: Unify 3DSTATE_PS emission

2016-11-14 Thread Timothy Arceri
On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote: In this patch we no longer do:   ps.RenderTargetResolveEnable = false; It would be nice to be consistent and either initialise everything or just drop all the lines setting things to false/0 and let the memset do its job. > --- >  src/int

[Mesa-dev] [PATCH 11/20] anv/pipeline: Unify 3DSTATE_PS emission

2016-11-12 Thread Jason Ekstrand
--- src/intel/vulkan/gen7_pipeline.c | 57 +--- src/intel/vulkan/gen8_pipeline.c | 38 +-- src/intel/vulkan/genX_pipeline_util.h | 70 +++ 3 files changed, 72 insertions(+), 93 deletions(-) diff --git a/src/intel/vu