Re: [Mesa-dev] [PATCH 10/23] mesa: refactor GetActiveAttrib

2015-03-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin One minor note -- not sure if it makes sense to call the _mesa_program_resource_prop helpers, but it is nicely generic. However you already have the ir_variable *var, so might as well use it? Your call. On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Instead of i

[Mesa-dev] [PATCH 10/23] mesa: refactor GetActiveAttrib

2015-03-13 Thread Tapani Pälli
Instead of iterating IR, retrieve required information through the new program resource functions. Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 58 -- 1 file changed, 27 insertions(+), 31 deletions(-) diff --git a/src/mesa/main/shader_