Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Roland Scheidegger
Am 02.10.2017 um 19:36 schrieb Emil Velikov: > On 2 October 2017 at 18:15, Matt Turner wrote: >> On Mon, Oct 2, 2017 at 6:17 AM, Emil Velikov >> wrote: >>> On 2 October 2017 at 07:59, Matt Turner wrote: >>> +#include "../../../mesa/main/texcompress_s3tc_tmp.h" >>> This feels a bit dir

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 18:15, Matt Turner wrote: > On Mon, Oct 2, 2017 at 6:17 AM, Emil Velikov wrote: >> On 2 October 2017 at 07:59, Matt Turner wrote: >> >>> +#include "../../../mesa/main/texcompress_s3tc_tmp.h" >>> >> This feels a bit dirty. If people are not too keen on the idea, >> another ap

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Matt Turner
On Mon, Oct 2, 2017 at 6:17 AM, Emil Velikov wrote: > On 2 October 2017 at 07:59, Matt Turner wrote: > >> +#include "../../../mesa/main/texcompress_s3tc_tmp.h" >> > This feels a bit dirty. If people are not too keen on the idea, > another approach is to have the code in src/util/ This is how the

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Nicolai Hähnle
On 02.10.2017 15:17, Emil Velikov wrote: On 2 October 2017 at 07:59, Matt Turner wrote: +#include "../../../mesa/main/texcompress_s3tc_tmp.h" This feels a bit dirty. If people are not too keen on the idea, another approach is to have the code in src/util/ I like that idea. Cheers, Nicolai

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 07:59, Matt Turner wrote: > +#include "../../../mesa/main/texcompress_s3tc_tmp.h" > This feels a bit dirty. If people are not too keen on the idea, another approach is to have the code in src/util/ -Emil ___ mesa-dev mailing list m

[Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Matt Turner
--- src/gallium/auxiliary/util/u_format.c | 4 -- src/gallium/auxiliary/util/u_format_s3tc.c| 54 +-- src/gallium/auxiliary/util/u_format_s3tc.h| 2 - src/gallium/drivers/llvmpipe/lp_screen.c | 4 -- src/gallium/drivers/llvmpipe/lp_test_format.c | 5