Re: [Mesa-dev] [PATCH 10/12] glsl: Minor cleanups after previous commit

2017-11-04 Thread Thomas Helland
Patches 6-10 are: Reviewed-by: Thomas Helland 2017-11-02 21:25 GMT+01:00 Ian Romanick : > From: Ian Romanick > > I think it's more clear to only call emit_access once. The only > difference between the two calls is the value of size_mul used for the > offset parameter... but you really have to

[Mesa-dev] [PATCH 10/12] glsl: Minor cleanups after previous commit

2017-11-02 Thread Ian Romanick
From: Ian Romanick I think it's more clear to only call emit_access once. The only difference between the two calls is the value of size_mul used for the offset parameter... but you really have to look at it to be sure. The s/is_64bit/is_double/ change is because there are no int64_t or uint64_