Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Marek Olšák
On Fri, Nov 9, 2012 at 1:23 AM, Dave Airlie wrote: + >>> >>> I would prefer if the constant buffers were updated only if the >>> sampler views were updated as well, so that it's not updated in every >>> draw command that has a shader querying the array size. >> >> probably makes sense, I was

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Dave Airlie
On Fri, Nov 9, 2012 at 10:23 AM, Dave Airlie wrote: + >>> >>> I would prefer if the constant buffers were updated only if the >>> sampler views were updated as well, so that it's not updated in every >>> draw command that has a shader querying the array size. >> >> probably makes sense, I was

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Dave Airlie
>>> + >> >> I would prefer if the constant buffers were updated only if the >> sampler views were updated as well, so that it's not updated in every >> draw command that has a shader querying the array size. > > probably makes sense, I was mostly thinking that nobody would use this > that often, an

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Dave Airlie
On Thu, Nov 8, 2012 at 11:01 PM, Marek Olšák wrote: > On Tue, Nov 6, 2012 at 11:16 PM, Dave Airlie wrote: >> This contains the evergreen support. >> >> Support is possible on rv670 upwards and the code in here >> should work, but it doesn't and I haven't debugged it to >> figure out why. >> >> Be

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Marek Olšák
On Tue, Nov 6, 2012 at 11:16 PM, Dave Airlie wrote: > This contains the evergreen support. > > Support is possible on rv670 upwards and the code in here > should work, but it doesn't and I haven't debugged it to > figure out why. > > Beyond just adding support for the cube map array sampling, > r6

[Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-06 Thread Dave Airlie
This contains the evergreen support. Support is possible on rv670 upwards and the code in here should work, but it doesn't and I haven't debugged it to figure out why. Beyond just adding support for the cube map array sampling, r600 resinfo isn't conformant with the GL specification, which states