Re: [Mesa-dev] [PATCH 10/10] egl: add EGL_platform_device support

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 12:16, Eric Engestrom wrote: >> +static int >> +_eglCompareDeviceDisplay(_EGLDisplay *dpy, void *plat_opt) > > This is a true/false check, so we I think should return a bool and > change name to reflect which "comparison" returns true, and you could > avoid the inline cast by

Re: [Mesa-dev] [PATCH 10/10] egl: add EGL_platform_device support

2018-08-29 Thread Eric Engestrom
On Friday, 2018-08-03 13:44:26 +0100, Emil Velikov wrote: > From: Emil Velikov > > This new 'platform' is added by default with no guards. > > It is effectively a copy of the surfaceless one, with updated function > names and brand new probe function. > > Due to the reuse, some of the ifdef HAV

[Mesa-dev] [PATCH 10/10] egl: add EGL_platform_device support

2018-08-03 Thread Emil Velikov
From: Emil Velikov This new 'platform' is added by default with no guards. It is effectively a copy of the surfaceless one, with updated function names and brand new probe function. Due to the reuse, some of the ifdef HAVE_SURFACELESS_PLATFORM guards have been dropped. A worthy mention are the