Re: [Mesa-dev] [PATCH 1/9] util: fix undefined behavior

2012-04-08 Thread nobled
On Sun, Apr 8, 2012 at 4:28 AM, Tolga Dalman wrote: > On 06.04.2012 17:38, nobled wrote: >> On Mon, Apr 2, 2012 at 7:40 AM, Tolga Dalman >> wrote: >> Hi, >> >> >> On 02.04.2012 00:24, nobled wrote: >  #define LIST_FOR_EACH_ENTRY(pos, head, member)                           >     \ >

Re: [Mesa-dev] [PATCH 1/9] util: fix undefined behavior

2012-04-08 Thread Tolga Dalman
On 06.04.2012 17:38, nobled wrote: > On Mon, Apr 2, 2012 at 7:40 AM, Tolga Dalman > wrote: > Hi, > > > On 02.04.2012 00:24, nobled wrote: #define LIST_FOR_EACH_ENTRY(pos, head, member) \ - for (pos = container_of((head)->next, pos, member);

Re: [Mesa-dev] [PATCH 1/9] util: fix undefined behavior

2012-04-06 Thread nobled
On Mon, Apr 2, 2012 at 7:40 AM, Tolga Dalman wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > > On 02.04.2012 00:24, nobled wrote: >>  #define LIST_FOR_EACH_ENTRY(pos, head, member)                               >> \ >> -   for (pos = container_of((head)->next, pos, member);  

Re: [Mesa-dev] [PATCH 1/9] util: fix undefined behavior

2012-04-02 Thread Tolga Dalman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 02.04.2012 00:24, nobled wrote: > #define LIST_FOR_EACH_ENTRY(pos, head, member) > \ > - for (pos = container_of((head)->next, pos, member); > \ > + for (pos = NULL, pos = container_of

[Mesa-dev] [PATCH 1/9] util: fix undefined behavior

2012-04-01 Thread nobled
container_of() can legally return anything, even invalid addresses that cause segfaults, when 'sample' is an uninitialized pointer. Bug exposed by clang. NOTE: This is a candidate for the 8.0 branch. --- src/gallium/auxiliary/util/u_double_list.h | 15 ++- 1 files changed, 10 inser