Re: [Mesa-dev] [PATCH 1/8] nir: Document a couple instances of parent_instr

2018-06-06 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 2:33 PM, Ian Romanick wrote: > From: Ian Romanick > > nir_ssa_def::parent_instr and nir_src::parent_instr have the same name, > but they mean really different things. I choose to save the next person > the hour+ that I just spent figuring that out. Even now that I know,

[Mesa-dev] [PATCH 1/8] nir: Document a couple instances of parent_instr

2018-06-06 Thread Ian Romanick
From: Ian Romanick nir_ssa_def::parent_instr and nir_src::parent_instr have the same name, but they mean really different things. I choose to save the next person the hour+ that I just spent figuring that out. Even now that I know, I doubt I'd notice in code review that someone typed foo->paren