Re: [Mesa-dev] [PATCH 1/8] nir: Add a pass for lowering away constant initializers

2016-12-05 Thread Jason Ekstrand
On Thu, Jul 21, 2016 at 2:52 AM, Iago Toral wrote: > On Wed, 2016-07-20 at 15:28 -0700, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand > > --- > > src/compiler/Makefile.sources | 1 + > > src/compiler/nir/nir.h | 2 + > > src/compile

Re: [Mesa-dev] [PATCH 1/8] nir: Add a pass for lowering away constant initializers

2016-07-21 Thread Iago Toral
I dropped a few minor comments in patches 1, 2, 4 and 5, I don't think any of them are very relevant, so feel free to ignore them. Otherwise: Patches 1-5 and 7-8 are: Reviewed-by: Iago Toral Quiroga On Wed, 2016-07-20 at 15:28 -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- >

Re: [Mesa-dev] [PATCH 1/8] nir: Add a pass for lowering away constant initializers

2016-07-21 Thread Iago Toral
On Wed, 2016-07-20 at 15:28 -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- >  src/compiler/Makefile.sources  |   1 + >  src/compiler/nir/nir.h |   2 + >  src/compiler/nir/nir_lower_constant_initializers.c | 102 > +

[Mesa-dev] [PATCH 1/8] nir: Add a pass for lowering away constant initializers

2016-07-20 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_lower_constant_initializers.c | 102 + 3 files changed, 105 insertions(+) create mode 100644 src/comp