Re: [Mesa-dev] [PATCH 1/8] nir/builder: Add support for easily building control-flow

2017-02-27 Thread Samuel Iglesias Gonsálvez
On 24/02/17 21:54, Jason Ekstrand wrote: > On Fri, Feb 24, 2017 at 6:05 AM, Samuel Iglesias Gonsálvez > mailto:sigles...@igalia.com>> wrote: > > > > On 24/02/17 02:14, Jason Ekstrand wrote: > > Each of the pop functions (and push_else) take a control flow > parameter as > > the

Re: [Mesa-dev] [PATCH 1/8] nir/builder: Add support for easily building control-flow

2017-02-24 Thread Jason Ekstrand
On Fri, Feb 24, 2017 at 6:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > > > On 24/02/17 02:14, Jason Ekstrand wrote: > > Each of the pop functions (and push_else) take a control flow parameter > as > > their second argument. If NULL, it assumes that the builder is in a > block

Re: [Mesa-dev] [PATCH 1/8] nir/builder: Add support for easily building control-flow

2017-02-24 Thread Samuel Iglesias Gonsálvez
On 24/02/17 02:14, Jason Ekstrand wrote: > Each of the pop functions (and push_else) take a control flow parameter as > their second argument. If NULL, it assumes that the builder is in a block > that's a direct child of the control-flow node you want to pop off the > virtual stack. This is wha

[Mesa-dev] [PATCH 1/8] nir/builder: Add support for easily building control-flow

2017-02-23 Thread Jason Ekstrand
Each of the pop functions (and push_else) take a control flow parameter as their second argument. If NULL, it assumes that the builder is in a block that's a direct child of the control-flow node you want to pop off the virtual stack. This is what 90% of consumers will want. The SPIR-V pass, how