Re: [Mesa-dev] [PATCH 1/8] meta: Fix blit shader compile on non-glsl-130 drivers.

2014-02-14 Thread Kenneth Graunke
On 02/14/2014 07:04 PM, Ian Romanick wrote: > On 02/14/2014 05:09 PM, Kenneth Graunke wrote: >> On 02/14/2014 03:00 PM, Eric Anholt wrote: >>> Compare this VS to the one for the post-130 case. Fixes piglit >>> glsl-lod-bias, and presumably tons of other code (I haven't done >>> a full piglit run

Re: [Mesa-dev] [PATCH 1/8] meta: Fix blit shader compile on non-glsl-130 drivers.

2014-02-14 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/2014 05:09 PM, Kenneth Graunke wrote: > On 02/14/2014 03:00 PM, Eric Anholt wrote: >> Compare this VS to the one for the post-130 case. Fixes piglit >> glsl-lod-bias, and presumably tons of other code (I haven't done >> a full piglit run on

Re: [Mesa-dev] [PATCH 1/8] meta: Fix blit shader compile on non-glsl-130 drivers.

2014-02-14 Thread Kenneth Graunke
On 02/14/2014 03:00 PM, Eric Anholt wrote: > Compare this VS to the one for the post-130 case. Fixes piglit > glsl-lod-bias, and presumably tons of other code (I haven't done a full > piglit run on swrast). > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74911 > --- > src/mesa/drivers

Re: [Mesa-dev] [PATCH 1/8] meta: Fix blit shader compile on non-glsl-130 drivers.

2014-02-14 Thread Ian Romanick
On 02/14/2014 03:00 PM, Eric Anholt wrote: > Compare this VS to the one for the post-130 case. Fixes piglit > glsl-lod-bias, and presumably tons of other code (I haven't done a full > piglit run on swrast). Looks like a good fix. If we had NV_explicit_attrib_location[1], we could easily unify a

[Mesa-dev] [PATCH 1/8] meta: Fix blit shader compile on non-glsl-130 drivers.

2014-02-14 Thread Eric Anholt
Compare this VS to the one for the post-130 case. Fixes piglit glsl-lod-bias, and presumably tons of other code (I haven't done a full piglit run on swrast). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74911 --- src/mesa/drivers/common/meta.c | 2 +- 1 file changed, 1 insertion(+), 1