Re: [Mesa-dev] [PATCH 1/8] mesa: Implement helper functions to map and unmap a VAO.

2019-03-12 Thread Brian Paul
The series looks great. Just a few minor suggestions below. Reviewed-by: Brian Paul BTW, I happened to look at _mesa_primitive_restart_index(). It seems we could/should add an assertion in there: assert(index_size == 1 || index_size == 2 || index_size == 4); right? -Brian

[Mesa-dev] [PATCH 1/8] mesa: Implement helper functions to map and unmap a VAO.

2019-03-05 Thread Mathias . Froehlich
From: Mathias Fröhlich Provide a set of functions that maps or unmaps all VBOs held in a VAO. The functions will be used in the following patches. Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.c | 84 src/mesa/main/arrayobj.h | 18 +