Re: [Mesa-dev] [PATCH 1/8] mesa/program: Translate csel operation from GLSL IR.

2017-01-27 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Tue, 2017-01-24 at 15:26 -0800, Francisco Jerez wrote: > This will be used internally by the GLSL front-end in order to > implement some built-in functions. Plumb it through MESA IR for > back-ends that rely on this translation pass. > --- > src/mesa/progra

Re: [Mesa-dev] [PATCH 1/8] mesa/program: Translate csel operation from GLSL IR.

2017-01-24 Thread Ian Romanick
I'd swear that I wrote a nearly identical patch almost 2 years ago. The work that depended on it fizzled, so I never sent it out. The one difference is I had the following comment: /* We assume that Boolean true and false are 1.0 and 0.0. OPCODE_CMP * selects src1 if src0 is < 0, sr

[Mesa-dev] [PATCH 1/8] mesa/program: Translate csel operation from GLSL IR.

2017-01-24 Thread Francisco Jerez
This will be used internally by the GLSL front-end in order to implement some built-in functions. Plumb it through MESA IR for back-ends that rely on this translation pass. --- src/mesa/program/ir_to_mesa.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/program