Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-20 Thread Jose Fonseca
On 13/02/15 00:49, Eric Anholt wrote: Jose Fonseca writes: Thanks for doing this. I appreciate it. I have no objection with the series. I'm happy to see more reuse. We can always move things around later, and it will be much easier when then are less entangled/duplicated. We'll need to upd

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-12 Thread Eric Anholt
Jose Fonseca writes: > Thanks for doing this. I appreciate it. > > I have no objection with the series. I'm happy to see more reuse. We > can always move things around later, and it will be much easier when > then are less entangled/duplicated. > > We'll need to update SCons include paths too

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-12 Thread Jose Fonseca
Thanks for doing this. I appreciate it. I have no objection with the series. I'm happy to see more reuse. We can always move things around later, and it will be much easier when then are less entangled/duplicated. We'll need to update SCons include paths too. If you have a git repos with

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-11 Thread Eric Anholt
Matt Turner writes: > On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt wrote: >> --- > > Maybe I just read what I wanted to read in the cover letter, but I was > expecting you to move u_math.h to src/util instead of this patch. > > That doesn't work because of u_math's inclusion of pipe/p_compiler.h

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-11 Thread Matt Turner
On Wed, Feb 11, 2015 at 5:02 PM, Matt Turner wrote: > On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt wrote: >> --- > > Maybe I just read what I wanted to read in the cover letter, but I was > expecting you to move u_math.h to src/util instead of this patch. > > That doesn't work because of u_math's

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-11 Thread Matt Turner
On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt wrote: > --- Maybe I just read what I wanted to read in the cover letter, but I was expecting you to move u_math.h to src/util instead of this patch. That doesn't work because of u_math's inclusion of pipe/p_compiler.h? ___

[Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-11 Thread Eric Anholt
--- src/glsl/Makefile.am | 2 ++ src/mesa/drivers/dri/common/Makefile.am | 2 ++ src/mesa/drivers/dri/i915/Makefile.am| 2 ++ src/mesa/drivers/dri/i965/Makefile.am| 2 ++ src/mesa/drivers/dri/nouveau/Makefile.am | 2 ++ src/mesa/drivers/dri/r200/Makefile.am| 2 ++