Re: [Mesa-dev] [PATCH 1/7] isl: Drop misplaced comment about padding

2017-03-14 Thread Nanley Chery
On Mon, Mar 13, 2017 at 03:27:58PM -0700, Chad Versace wrote: > isl has a giant comment that explains the hardware's padding > requirements. (Hint: Cache lines and page faults). But the comment is in > the wrong place, in isl_calc_linear_row_pitch(), which is unrelated to > padding. > > The import

[Mesa-dev] [PATCH 1/7] isl: Drop misplaced comment about padding

2017-03-13 Thread Chad Versace
isl has a giant comment that explains the hardware's padding requirements. (Hint: Cache lines and page faults). But the comment is in the wrong place, in isl_calc_linear_row_pitch(), which is unrelated to padding. The important parts of that comment were copied to isl_apply_surface_padding() long