Re: [Mesa-dev] [PATCH 1/6] translate_generic: use memcpy if possible

2010-08-13 Thread Luca Barbieri
> In this change you've got an int value (copy_size) which has some > special meaning when negative -- can you add comments explaining what > the meaning of a negative size is?  Is there a way to use some more > explicit flag value to indicate this condition? I think it makes sense, since -1 stand

[Mesa-dev] [PATCH 1/6] translate_generic: use memcpy if possible (v2)

2010-08-13 Thread Luca Barbieri
Changes in v2: - Add comment regarding copy_size When used in GPU drivers, translate can be used to simultaneously perform a gather operation, and convert away from unsupported formats. In this use case, input and output formats will often be identical: clearly it would make sense to use a memcpy

Re: [Mesa-dev] [PATCH 1/6] translate_generic: use memcpy if possible

2010-08-13 Thread Keith Whitwell
Luca, In this change you've got an int value (copy_size) which has some special meaning when negative -- can you add comments explaining what the meaning of a negative size is? Is there a way to use some more explicit flag value to indicate this condition? Keith On Thu, 2010-08-12 at 10:08 -070

[Mesa-dev] [PATCH 1/6] translate_generic: use memcpy if possible

2010-08-12 Thread Luca Barbieri
When used in GPU drivers, translate can be used to simultaneously perform a gather operation, and convert away from unsupported formats. In this use case, input and output formats will often be identical: clearly it would make sense to use a memcpy in this case. Instead, translate will insist to