Re: [Mesa-dev] [PATCH 1/6] nir/builder: Add the nir_imm_ivec3() helper

2019-06-18 Thread Boris Brezillon
On Mon, 17 Jun 2019 06:51:15 -0700 Alyssa Rosenzweig wrote: > Reviewed-by, seems like a good idea to have the full set :) I don't intend to post a v2 of that patch since the rework proposed by Jason means we no longer call nir_imm_vec4(). If you think it's still worth applying it, feel free to p

Re: [Mesa-dev] [PATCH 1/6] nir/builder: Add the nir_imm_ivec3() helper

2019-06-17 Thread Alyssa Rosenzweig
Reviewed-by, seems like a good idea to have the full set :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/6] nir/builder: Add the nir_imm_ivec3() helper

2019-06-17 Thread Boris Brezillon
We already have nir_imm_ivec2() and nir_imm_ivec4(), let's add nir_imm_ivec3() instead of open-coding the logic. Signed-off-by: Boris Brezillon --- src/compiler/nir/nir_builder.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/